fix parsing dynamic path for assets field in a matrix field #1501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angrybrad
deleted the
bugfix/1477-matrix-field-with-assets-with-dynamic-subpath
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When parsing an assets field that’s inside of a matrix field, we can no longer pass the root element to the
craft\feedme\fields\Assets.Importing into an assets field inside of a matrix field, where the assets field had a dynamic subpath set, worked in v4 because getting an owner of a root entry (even via
{{ dump(entry.owner) }}) returned that entry.In v5, it’ll return
null, causing the dynamic path to fail. If the owner isnull, then{{ owner.slug }}will benull, causing this check to get triggered.With this PR, the dynamic path will resolve as expected.
Related issues
#1477