Skip to content

Commit

Permalink
remove redundant title=""
Browse files Browse the repository at this point in the history
  • Loading branch information
bbannon committed Jun 18, 2024
1 parent 7a1c4dd commit 2ad1207
Show file tree
Hide file tree
Showing 19 changed files with 101 additions and 114 deletions.
3 changes: 1 addition & 2 deletions activity_log.php
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,7 @@
if ( $row = dbi_fetch_row ( $res ) )
// Go FORWARD in time.
echo '
<a title="' . $nextStr . '&nbsp;' . $PAGE_SIZE . '&nbsp;' . $eventsStr
. '" class="next" href="activity_log.php' . ( $row[0] <= $previd
<a class="next" href="activity_log.php' . ( $row[0] <= $previd
? ( $sys ? '?system=1' : '' )
: '?startid=' . $previd . ( $sys ? '&amp;system=1' : '' ) ) . '">'
. $nextStr . '&nbsp;' . $PAGE_SIZE . '&nbsp;' . $eventsStr . '</a><br>';
Expand Down
4 changes: 2 additions & 2 deletions availability.php
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,10 @@

echo '
<div style="width:99%;">
<a title="' . $prevStr . '" class="prev" href="' . $prev_url
<a class="prev" href="' . $prev_url
. '"><img src="images/bootstrap-icons/arrow-left-circle.svg" class="prev" alt="'
. $prevStr . '"></a>
<a title="' . $nextStr . '" class="next" href="' . $next_url
<a class="next" href="' . $next_url
. '"><img src="images/bootstrap-icons/arrow-right-circle.svg" class="next" alt="'
. $nextStr . '"></a>
<div class="title">
Expand Down
2 changes: 1 addition & 1 deletion category.php
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@

if (!empty($V['cat_icon_mime'])) {
echo '<img src="getIcon.php?cat_id=' . $K . '" alt="'
. $catIconStr . '" title="' . $catIconStr . '">';
. $catIconStr . '">';
}
echo '</li>';
}
Expand Down
4 changes: 2 additions & 2 deletions help_index.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@
//display About WebCalendar link only on index page
$aboutStr = translate ( 'About WebCalendar' );
echo '
<li><a title="' . $aboutStr . '" href="" onclick="javascript:openAbout()">'
<li><a href="" onclick="javascript:openAbout()">'
. $aboutStr . '</a></li>';
foreach ( $help_list as $key => $val ) {
$page++;
$transStr = translate ( $key );
echo '
<li><a title="' . $transStr . '" href="' . $val . '?thispage=' . $page
<li><a href="' . $val . '?thispage=' . $page
. '">' . $transStr . '</a></li>';
}
echo '
Expand Down
4 changes: 2 additions & 2 deletions icons.php
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@
for ($i = 0, $cnt = count($icons); $i < $cnt; $i++) {
echo '
<td><a href="#" onclick="sendURL(\'' . $icon_path . $icons[$i]
. '\');" ><img src="' . $icon_path . $icons[$i] . '" title="'
. $title_str . '" alt="' . $title_str . '"></a></td>'
. '\');" ><img src="' . $icon_path . $icons[$i]
. '" alt="' . $title_str . '"></a></td>'
. ($i > 0 && $i % 8 == 0 ? '
</tr>
<tr>' : '');
Expand Down
38 changes: 19 additions & 19 deletions includes/functions.php
Original file line number Diff line number Diff line change
Expand Up @@ -719,7 +719,7 @@ function daily_matrix ( $date, $participants, $popup = '' ) {
<a class="matrix" href="view_entry.php?id='
. $master[$participants[$i]][$r]['ID']
. '&friendly=1"><img src="images/pix' . ( $tmpMast = 'A' ? '' : 'b' )
. '.gif" title="' . $viewMsg . '" alt="' . $viewMsg . '"></a>';
. '.gif" alt="' . $viewMsg . '"></a>';
}

$ret .= '
Expand All @@ -738,9 +738,9 @@ function daily_matrix ( $date, $participants, $popup = '' ) {
</table><br>
<table class="aligncenter">
<tr>
<td class="matrixlegend"><img src="images/pix.gif" title="{$busy}"
<td class="matrixlegend"><img src="images/pix.gif"
alt="{$busy}">{$busy}&nbsp;&nbsp;&nbsp;<img src="images/pixb.gif"
title="{$tentative}" alt="{$tentative}">{$tentative}</td>
alt="{$tentative}">{$tentative}</td>
</tr>
</table>
EOT;
Expand Down Expand Up @@ -984,8 +984,8 @@ function display_admin_link($break = true) {
$adminStr = translate ( 'Admin' );

return ( $break ? "<br>\n" : '' )
. ( $MENU_ENABLED == 'N' ? '<a title="' . $adminStr
. '" class="nav" href="adminhome.php">&laquo;&nbsp; ' . $adminStr
. ( $MENU_ENABLED == 'N' ? '<a'
. ' class="nav" href="adminhome.php">&laquo;&nbsp; ' . $adminStr
. '</a><br><br>' . "\n" : '' );
}

Expand Down Expand Up @@ -1156,10 +1156,10 @@ function display_navigation ( $name, $show_arrows = true, $show_cats = true ) {
. ( get_web_browser() == 'MSIE' ? ' style="zoom:1"' : '' )
. '>' . ( $show_arrows &&
( $name != 'month' || $DISPLAY_SM_MONTH == 'N' || $DISPLAY_TASKS == 'Y' ) ? '
<a title="' . $nextStr . '" class="next" href="' . $name . '.php?'
<a class="next" href="' . $name . '.php?'
. $u_url . 'date=' . $nextYmd . $caturl
. '"><img src="images/bootstrap-icons/arrow-right-circle.svg" alt="' . $nextStr . '"></a>
<a title="' . $prevStr . '" class="prev" href="' . $name . '.php?'
<a class="prev" href="' . $name . '.php?'
. $u_url . 'date=' . $prevYmd . $caturl
. '"><img src="images/bootstrap-icons/arrow-left-circle.svg" alt="' . $prevStr . '"></a>' : '' ) . '
<div class="title">
Expand Down Expand Up @@ -1247,10 +1247,10 @@ function display_small_month ( $thismonth, $thisyear, $showyear,
<thead>
<tr class="monthnav">
<th colspan="' . ( $DISPLAY_WEEKNUMBER == true ? 8 : 7 ) . '">
<a title="' . $prevStr . '" class="prev" href="day.php?' . $u_url
<a class="prev" href="day.php?' . $u_url
. 'date=' . $month_ago . $caturl
. '"><img src="images/bootstrap-icons/arrow-left-circle.svg" alt="' . $prevStr . '"></a>
<a title="' . $nextStr . '" class="next" href="day.php?' . $u_url
<a class="next" href="day.php?' . $u_url
. 'date=' . $month_ahead . $caturl
. '"><img src="images/bootstrap-icons/arrow-right-circle.svg" alt="' . $nextStr . '"></a>'
. date_to_str ( sprintf ( "%04d%02d%02d", $thisyear, $thismonth, 1 ),
Expand All @@ -1267,10 +1267,10 @@ function display_small_month ( $thismonth, $thisyear, $showyear,
<thead>
<tr class="monthnav">
<th colspan="7">
<a title="' . $prevStr . '" class="prev" href="minical.php?'
<a class="prev" href="minical.php?'
. $u_url . 'date=' . $month_ago
. '"><img src="images/bootstrap-icons/arrow-left-circle.svg" alt="' . $prevStr . '"></a>
<a title="' . $nextStr . '" class="next" href="minical.php?'
<a class="next" href="minical.php?'
. $u_url . 'date=' . $month_ahead
. '"><img src="images/bootstrap-icons/arrow-right-circle.svg" alt="' . $nextStr . '"></a>'
. date_to_str ( sprintf ( "%04d%02d%02d", $thisyear, $thismonth, 1 ),
Expand Down Expand Up @@ -1905,8 +1905,8 @@ function generate_activity_log ( $id = '', $sys = false, $startid = '' ) {
// Added TZ conversion
( ! empty ( $GENERAL_USE_GMT ) && $GENERAL_USE_GMT == 'Y' ? 3 : 2 ) )
. '</td>
<td>' . ( ! $sys && ! $id ? '<a title="' . htmlspecialchars ( $l_ename )
. '" href="view_entry.php?id=' . $l_eid . '">'
<td>' . ( ! $sys && ! $id ? '<a'
. ' href="view_entry.php?id=' . $l_eid . '">'
. htmlspecialchars ( $l_ename ) . '</a></td>
<td>' : '' ) . display_activity_log ( $l_type, $l_text ) . '</td>
</tr>';
Expand Down Expand Up @@ -3647,7 +3647,7 @@ function html_for_event_day_at_a_glance ( $event, $date ) {
if ( $getCat > 0 && file_exists ( $catIcon ) ) {
$catAlt = translate ( 'Category' ) . ': ' . $categories[$getCat]['cat_name'];
$hour_arr[$ind] .= '<img src="' . $catIcon . '" alt="' . $catAlt
. '" title="' . $catAlt . '">';
. '">';
}

if ( $getCalTypeName == 'task' ) {
Expand Down Expand Up @@ -3804,7 +3804,7 @@ function html_for_event_week_at_a_glance ( $event, $date,
if ( $getCat > 0 && file_exists ( $catIcon ) ) {
$catAlt = translate ( 'Category' ) . ': ' . $categories[$getCat]['cat_name'];
$hour_arr[$ind] .= '<img src="' . $catIcon . '" alt="' . $catAlt
. '" title="' . $catAlt . '">';
. '">';
}

// Build entry link if UAC permits viewing.
Expand Down Expand Up @@ -4690,13 +4690,13 @@ function print_date_entries ( $date, $user, $ssi = false,
$moon_title = ( empty ( $tmp ) ? '' : translate ( ucfirst ( $tmp )
. ( strpos ( 'fullnew', $tmp ) !== false ? '' : ' Quarter' ) . ' Moon' ) );
$ret = ( $can_add ? '
<a title="' . $newEntryStr . '" href="edit_entry.php?' . $userCatStr
<a href="edit_entry.php?' . $userCatStr
. 'date=' . $date . '"><img src="images/bootstrap-icons/plus-circle.svg" alt="' . $newEntryStr
. '" class="new"></a>' : '' ) . '
<a class="dayofmonth" href="day.php?' . $userCatStr . 'date=' . $date
. '">' . substr ( $date, 6, 2 ) . '</a>' . ( empty ( $tmp )
? '' : '<img src="images/' . $tmp . 'moon.gif" title="' . $moon_title
. '" alt="' . $moon_title . '">' ) . "<br>\n";
? '' : '<img src="images/' . $tmp . 'moon.gif"'
. ' alt="' . $moon_title . '">' ) . "<br>\n";
$cnt++;
}
// Get, combine and sort the events for this date.
Expand Down Expand Up @@ -4958,7 +4958,7 @@ function print_entry ( $event, $date ) {
? '' : translate ( 'Category' ) . ': '
. $categories[$catNum]['cat_name'] );

$ret .= $catIcon . '" alt="' . $catAlt . '" title="' . "$catAlt\">";
$ret .= $catIcon . '" alt="' . $catAlt . '">';
}

if ( $login != $loginStr && strlen ( $loginStr ) ) {
Expand Down
47 changes: 20 additions & 27 deletions includes/trailer.php
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
if ( ! empty ( $GLOBALS['HOME_LINK'] ) ) {
$home = $GLOBALS['HOME_LINK'];
$homeStr = translate ( 'Home' );
$goto_link[] = '<a title="' . $homeStr . '" class="bold" href=" '
$goto_link[] = '<a class="bold" href=" '
. "$home\">$homeStr" . '</a>';
}

Expand Down Expand Up @@ -78,22 +78,20 @@
if ( ! empty ( $user ) && $user != $login )
$todayURL .= '?user=' . $user;

$goto_link[] = '<a title="' . $todayStr . '" class="bold" href="'
$goto_link[] = '<a class="bold" href="'
. "$todayURL\">$todayStr" . '</a>';
}
if ( $login != '__public__' ) {
if ( ! $is_nonuser && $readonly == 'N' ) {
if( ( ! access_is_enabled()
|| access_can_access_function( ACCESS_ADMIN_HOME )
|| access_can_access_function( ACCESS_PREFERENCES ) ) )
$goto_link[] = '<a title="' . $adminStr
. '" class="bold" href="adminhome.php'
$goto_link[] = '<a class="bold" href="adminhome.php'
. ( $is_nonuser_admin ? '?user=' . $user : '' )
. "\">$adminStr" . '</a>';

if ( $REQUIRE_APPROVALS == 'Y' || $PUBLIC_ACCESS == 'Y' )
$goto_link[] = '<a title="' . $unapprovedStr
. '" href="list_unapproved.php'
$goto_link[] = '<a href="list_unapproved.php'
. ( $is_nonuser_admin ? '?user=' . getValue ( 'user' ) : '' )
. "\">$unapprovedStr" . '</a>';
}
Expand All @@ -109,33 +107,32 @@
$ulist = array_merge( get_my_users(), get_my_nonusers( $login, true ) );
if ( count ( $ulist ) > 1 ) {
$calStr = translate ( 'Another Users Calendar' );
$goto_link[] = '<a title="' . $calStr . '" href="select_user.php">'
$goto_link[] = '<a href="select_user.php">'
. $calStr . '</a>';
}
}
} else {
$goto_link[] = '<a title="' . $myCalStr . '" class="bold" href="'
$goto_link[] = '<a class="bold" href="'
. "$mycal\">$myCalStr" . '</a>';
$goto_link[] = '<a title="' . $todayStr . '" class="bold" href="'
$goto_link[] = '<a class="bold" href="'
. "$todayURL\">$todayStr" . '</a>';

if ( $readonly == 'N' )
$goto_link[] = '<a title="' . $adminStr
. '" class="bold" href="adminhome.php">' . $adminStr . '</a>';
$goto_link[] = '<a class="bold" href="adminhome.php">' . $adminStr . '</a>';
}
// Only display some links if we're viewing our own calendar.
if ( empty ( $user ) || $user == $login ) {
if ( access_can_access_function ( ACCESS_SEARCH ) )
$goto_link[] = '<a title="' . $searchStr . '" href="search.php">'
$goto_link[] = '<a href="search.php">'
. $searchStr . '</a>';

if ( $login != '__public__' && ! $is_nonuser && $readonly != 'Y' ) {
if ( access_can_access_function ( ACCESS_IMPORT ) )
$goto_link[] = '<a title="' . $importStr . '" href="import.php">'
$goto_link[] = '<a href="import.php">'
. $importStr . '</a>';

if ( access_can_access_function ( ACCESS_EXPORT ) )
$goto_link[] = '<a title="' . $exportStr . '" href="export.php">'
$goto_link[] = '<a href="export.php">'
. $exportStr . '</a>';
}
if ( $can_add ) {
Expand All @@ -144,13 +141,12 @@
. ( ! empty ( $thismonth ) ? '&amp;month=' . $thismonth : '' )
. ( ! empty ( $thisday ) ? '&amp;day=' . $thisday : '' );

$goto_link[] = '<a title="' . $addNewEntryStr . '" href="edit_entry.php'
$goto_link[] = '<a href="edit_entry.php'
. ( ! empty ( $thisyear ) ? '?' . $tmpYrStr : '' )
. '">' . $addNewEntryStr . '</a>';

if ( $DISPLAY_TASKS_IN_GRID == 'Y' || $DISPLAY_TASKS == 'Y' )
$goto_link[] = '<a title="' . $addNewTaskStr
. '" href="edit_entry.php?eType=task'
$goto_link[] = '<a href="edit_entry.php?eType=task'
. ( ! empty ( $thisyear ) ? '&amp;' . $tmpYrStr : '' )
. '">' . $addNewTaskStr . '</a>';
}
Expand All @@ -160,8 +156,7 @@
: ( $login != '__public__' && ! $is_nonuser ) );

if ( $showHelp )
$goto_link[] = '<a title="' . $helpStr
. '" href="#" onclick="javascript:openHelp()" '
$goto_link[] = '<a href="#" onclick="javascript:openHelp()" '
. 'onmouseover="window.status=\'\'; return true">' . $helpStr . '</a>';

if ( count ( $goto_link ) > 0 ) {
Expand All @@ -177,8 +172,7 @@
$viewcnt = count ( $views );
if ( ( access_can_access_function ( ACCESS_VIEW ) && $ALLOW_VIEW_OTHER != 'N' ) && $viewcnt > 0 ) {
for ( $i = 0; $i < $viewcnt; $i++ ) {
$views_link[] = '<a title="' . htmlspecialchars ( $views[$i]['cal_name'] )
. '" href="' . $views[$i]['url']
$views_link[] = '<a href="' . $views[$i]['url']
. ( ! empty ( $thisdate ) ? '&amp;date=' . $thisdate : '' )
. '">' . htmlspecialchars ( $views[$i]['cal_name'] ) . "</a>\n";
}
Expand All @@ -204,8 +198,7 @@
if ( $rows ) {
for ( $i = 0, $cnt = count ( $rows ); $i < $cnt; $i++ ) {
$row = $rows[$i];
$reports_link[] = '<a title="' . htmlspecialchars ( $row[0] )
. '" href="report.php?report_id=' . $row[1]
$reports_link[] = '<a href="report.php?report_id=' . $row[1]
. ( ! empty ( $user ) && $user != $login ? '&amp;user=' . $user : '' )
. '">' . htmlspecialchars ( $row[0] ) . '</a>';
}
Expand Down Expand Up @@ -247,10 +240,10 @@
if ( $readonly != 'Y' )
$tret .= '<br><span class="prefix">' . $currentUserStr . ':</span>&nbsp;'
. ( strlen ( $login ) && $login != '__public__'
? $fullname . '&nbsp;(<a title="' . $logoutStr . '" href="'
? $fullname . '&nbsp;(<a href="'
. $logout_url . '">' . $logoutStr
: // For public user (who did not actually login).
$publicStr . '&nbsp;(<a title="' . $loginStr . '" href="' . $login_url
$publicStr . '&nbsp;(<a href="' . $login_url
. '">' . $loginStr ) . "</a>)\n";
}

Expand Down Expand Up @@ -301,7 +294,7 @@
// Year does not show events, so you cannot manage someone's cal.
}
$groups .= ( $i > 0 && $groups != '' ? ", \n" : '' )
. '<a title="' . "$f\" href=\"$xurl\">$f".'</a>';
. "<a href=\"$xurl\">$f".'</a>';
}
if ( ! empty ( $groups ) )
$tret .= '<br><span class="prefix">'
Expand All @@ -310,7 +303,7 @@

// WebCalendar Info...
$tret .= '<br><br>
<a title="' . $GLOBALS['PROGRAM_NAME'] . '" id="programname" href="'
<a id="programname" href="'
. $GLOBALS['PROGRAM_URL'] . '" target="_blank">' . $GLOBALS['PROGRAM_NAME']
. "</a>\n" . '</div></div>
<!-- /TRAILER -->' . "\n";
Expand Down
5 changes: 2 additions & 3 deletions list_unapproved.php
Original file line number Diff line number Diff line change
Expand Up @@ -149,9 +149,8 @@ function list_unapproved ( $user ) {
<tr>
<td colspan="5" nowrap>&nbsp;
<img src="images/bootstrap-icons/arrow-90deg-up.svg" alt="">
<label><a title="' . $checkAllStr . '" onclick="check_all( \''
. $user . '\' );">' . $checkAllStr . '</a> / <a title="' . $uncheckAllStr
. '" onclick="uncheck_all( \'' . $user . '\' );">' . $uncheckAllStr
<label><a onclick="check_all( \''
. $user . '\' );">' . $checkAllStr . '</a> / <a onclick="uncheck_all( \'' . $user . '\' );">' . $uncheckAllStr
. '</a></label>&nbsp;&nbsp;&nbsp;
<input type="image" src="images/bootstrap-icons/check-circle.svg" title="' . $appSelStr
. '" onclick="return do_confirm( \'approveSelected\', \'' . $cal_user
Expand Down
14 changes: 5 additions & 9 deletions report.php
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ function event_to_text ( $event, $date ) {
if ( $PUBLIC_ACCESS == 'Y' ) {
$clickStr =
translate ( 'Click here to manage reports for the Public Access calendar.' );
$list .= '<p><a title="' . $clickStr . '" href="report.php?public=1">'
$list .= '<p><a href="report.php?public=1">'
. $clickStr . '</a></p>';
}
$sql .= '? OR cal_is_global = \'Y\'';
Expand Down Expand Up @@ -250,7 +250,7 @@ function event_to_text ( $event, $date ) {
</ul>';
$addurl = 'edit_report.php' . ( $updating_public ? '?public=1' : '' );
$list .= '
<p><a class="btn btn-primary" title="' . $addStr . '" href="' . $addurl . '" class="nav">'
<p><a class="btn btn-primary" href="' . $addurl . '" class="nav">'
. $addStr . '</a></p>';
dbi_free_result ( $res );
} else
Expand Down Expand Up @@ -461,18 +461,14 @@ function event_to_text ( $event, $date ) {
}

$adminLinkStr = $manageStr = $nextLinkStr = $prevLinkStr = $textStr = '';
$nextStr = translate ( 'Next' );
$prevStr = translate ( 'Previous' );
$reportNameStr = ( $include_header ? '
<h2>' . htmlentities($report_name) . '</h2>' : '' );

if ( ! empty ( $report_allow_nav ) && $report_allow_nav == 'Y' ) {
$temp = '" href="report.php?report_id=' . $report_id . $u_url . '&amp;offset=';

$nextLinkStr = $prevLinkStr = '
<a class="nav" title="';
$nextLinkStr .= $nextStr . $temp . $next . '">' . $nextStr . '</a>';
$prevLinkStr .= $prevStr . $temp . $prev . '">' . $prevStr . '</a>&nbsp;&nbsp;';
<a href="report.php?report_id=' . $report_id . $u_url . '&amp;offset=';
$nextLinkStr .= $next . '" class="nav">' . translate ( 'Next' ) . '</a>';
$prevLinkStr .= $prev . '" class="nav">' . translate ( 'Previous' ) . '</a>&nbsp;&nbsp;';
}

if ( empty ( $list ) ) {
Expand Down
Loading

0 comments on commit 2ad1207

Please sign in to comment.