-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposed .htaccess file. #17
base: master
Are you sure you want to change the base?
Conversation
It looks like only includes/js/v_h_scrolls.js made it here. There are several more functions in here that I find useful.
php_flag magic_quotes_runtime Off | ||
php_flag magic_quotes_sybase Off | ||
|
||
php_value date.default_latitude 43.133 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would be setting default lot/lon to this value? Seems odd...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean "latutude/longitude"? Those are my area. I was looking to put in sunrise/sunset info on some page like month view.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, there should be a way to get the users timezone from them. If we track them in user_prefs
|
||
php_value date.default_latitude 43.133 | ||
php_value date.default_longitude -115.6912 | ||
php_value date.timezone America/Boise |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, why override their system setting for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what you're asking. If you mean things like 'magic_quotes' or 'register_global', I wanted to make sure I was coding without them.
If you mean 'default_charset' I was looking to make all translation/*.txt files UTF-8. Would eliminate half the files. And update_translation.pl used to barf on BOM files. Which is why Bulgarian.txt got corrupted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was referring to timezone here. Seems like if we include a version of this file, that value should be commented out with some info on how it can be used. Are you thinking the installer will write/update this file? Or it would just be a regular file included with the release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, more comments. On all entries.
This one was supposed to be an example. Included with the release.
And on the admin page, (or maybe just the installer?), ask what the defaults should be and create the real file on the fly.
I intended for the system admin to set defaults for their site. Just once.
For instance, my ISP has timezone = UTC. I live in Idaho. Not very helpful.
If we could access GPS/location info, latitude/longitude, and track that in user_prefs, we could keep traveling boss/assistant timezones updated. Without trying to guess.
|
||
# 'magic_quotes' were removed in PHP 7. | ||
# Remove these lines if you're using PHP >= 7. | ||
php_flag magic_quotes_gpc Off |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be nice... to be able to force this setting off right from within webcalendar.
@@ -0,0 +1,558 @@ | |||
/* $Id: chapman.js,v 1.1 2013/01/30 10:02:28 bbannon Exp $ */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not clear on what the intent for this new file is. How will this be used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was mostly planning on using it for the Date functions.
Also, it has the scrollers from v_h_scrolls.js incorporated.
There are a couple of other functions that looked interesting but, I don't have solid plans for them, yet. I put them in just in case.
Another thing to consider.... A lot of people use nginx now instead of Apache, and nginx does not support htaccess files. |
hmmm... I've only seen nginx mentioned somewhere in passing. |
I like the idea of providing it as an example. However, we would need to put the .htaccess file somewhere other than the root directory, or name it something else (.htaccess-example). |
Good idea. Put it where it belongs just named .htaccess-example or something like that. |
We might also want to put .htaccess in .gitignore. |
I just watched a course on nginx at https://www.sitepoint.com/premium/courses/faster-websites-with-nginx-2757 |
For the people who are able to use an .htaccess, it may solve a couple of problems.