let's try again #419
Closed
let's try again #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ummmm... definitely do not want to add the |
|
OK. I can see that.
But, I had to delete the line for 'vendor' dir in my .gitignore to even see
it for either upload or download.
So, while I think it needs to be somewhere in the repo where devs can get
to it,
I don't think it has to be in the main distribution files. I may be wrong.
If you want to just change the composer files,
I deleted the lines in the require section,
ran require for each one in alphabetic order
(because I wanted to see if they were inserted in the order i typed them;
they are)
including adding components/font-awesome and components/normalize.css.
|
|
Have you tested WebCalendar with bootstrap 5? Last time I looked, it wasn't a drop-in replacement for bootstrap 4. |
|
I have trouble with bootstrap any version.
I don't know what I'm doing wrong.
One reason I'm trying font-awesome.
…On Thu, Sep 21, 2023 at 9:08 PM Craig Knudsen ***@***.***> wrote:
Have you tested WebCalendar with bootstrap 5? Last time I looked, it
wasn't a drop-in replacement for bootstrap 4.
—
Reply to this email directly, view it on GitHub
<#419 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHJ7GLWRWOAXLMQ7QUX3YZTX3T6L7ANCNFSM6AAAAAA5AVM5K4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
What do you mean by "trying font-awesome"? I would think there would be a lot of CSS and other changes with a pull request to switch over the font-awesome, so I'm a bit confused about this one. |
|
I'm still experimenting.
At the moment, I'm just hard coding the links into the vendor dir
…On Fri, Sep 22, 2023 at 7:49 AM Craig Knudsen ***@***.***> wrote:
What do you mean by "trying font-awesome"? I would think there would be a
lot of CSS and other changes with a pull request to switch over the
font-awesome, so I'm a bit confused about this one.
—
Reply to this email directly, view it on GitHub
<#419 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHJ7GLRAE5MPARHHQ22MYLDX3WJNHANCNFSM6AAAAAA5AVM5K4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I'm supposed to include composer.lock, too.
I also included the updated vendors, because why not?