Documentors #422
Merged
Documentors #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigk5n
reviewed
Sep 27, 2023
Comment on lines
+190
to
+199
| # $trans{ 'charset' } = '=' if ( !defined( $trans{ 'charset' } ) ); | ||
| # $trans{ 'direction' } = '=' if ( !defined( $trans{ 'direction' } ) ); | ||
| # $trans{ '__mm__/__dd__/__yyyy__' } = '=' | ||
| # if ( !defined( $trans{ '__mm__/__dd__/__yyyy__' } ) ); | ||
| # $trans{ '__month__ __dd__' } = '=' | ||
| # if ( !defined( $trans{ '__month__ __dd__' } ) ); | ||
| # $trans{ '__month__ __dd__, __yyyy__' } = '=' | ||
| # if ( !defined( $trans{ '__month__ __dd__, __yyyy__' } ) ); | ||
| # $trans{ '__month__ __yyyy__' } = '=' | ||
| # if ( !defined( $trans{ '__month__ __yyyy__' } ) ); |
There was a problem hiding this comment.
Why are we commenting this out? I thought it served a purpose at some point, but I don't know if it still does...
|
The original purpose was to cut the file size of the translation files.
But, it seems to cause unanticipated and intermittent problems.
I'm still trying to figure out why.
So turning it off for now.
…On Wed, Sep 27, 2023 at 1:50 PM Craig Knudsen ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tools/update_translation.pl
<#422 (comment)>:
> +# $trans{ 'charset' } = '=' if ( !defined( $trans{ 'charset' } ) );
+# $trans{ 'direction' } = '=' if ( !defined( $trans{ 'direction' } ) );
+# $trans{ '__mm__/__dd__/__yyyy__' } = '='
+# if ( !defined( $trans{ '__mm__/__dd__/__yyyy__' } ) );
+# $trans{ '__month__ __dd__' } = '='
+# if ( !defined( $trans{ '__month__ __dd__' } ) );
+# $trans{ '__month__ __dd__, __yyyy__' } = '='
+# if ( !defined( $trans{ '__month__ __dd__, __yyyy__' } ) );
+# $trans{ '__month__ __yyyy__' } = '='
+# if ( !defined( $trans{ '__month__ __yyyy__' } ) );
Why are we commenting this out? I thought it served a purpose at some
point, but I don't know if it still does...
—
Reply to this email directly, view it on GitHub
<#422 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHJ7GLWXJWUGZC5W4CJZVZDX4R7Q7ANCNFSM6AAAAAA5IBOSHY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a few lines that are no longer used.
A little re-formatting.