Create linter.yml #440
Closed
Create linter.yml #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let github lint everything.
Super linter said lines too long.
Need the folder for the reports.
We will need to set up the rules for each language.
Didn't actually need this.
|
Well damn. Need the folder, but not the file. I don't see how from here. |
Line too long and trailing whitespace.
Program didn't like extra whitespace.
craigk5n
reviewed
Nov 30, 2023
| ############################# | ||
| on: | ||
| push: | ||
| branches-ignore: [master, main] |
There was a problem hiding this comment.
Would be good to include "release" branch as well, but I can add that later
|
Can you explain what this is supposed to do? When I look at the action output, it doesn't look like it scanned any of the webcalendar files: https://github.com/craigk5n/webcalendar/actions/runs/7045472464/job/19175266697 |
|
It's supposed to lint everything; css, html, js, json, sql, php, scss
I don't think I have it quite set up correctly yet.
Been having problems with my computer.
…On Thu, Nov 30, 2023 at 9:47 AM Craig Knudsen ***@***.***> wrote:
Can you explain what this is supposed to do? When I look at the action
output, it doesn't look like it scanned any of the webcalendar files:
https://github.com/craigk5n/webcalendar/actions/runs/7045472464/job/19175266697
—
Reply to this email directly, view it on GitHub
<#440 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHJ7GLSUU5WWNS6AC3HNHN3YHDBCVAVCNFSM6AAAAAA7ZYABTWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZUGI3DOMZXGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I'll reopen this when I get it to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let github lint everything.