Skip to content

Add Bitplane Selection #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2024
Merged

Add Bitplane Selection #35

merged 2 commits into from
Jun 23, 2024

Conversation

craigthomas
Copy link
Owner

This PR adds a bitplane register to the CPU, along with an associated operation to set the bitplane to draw on. Additionally, this PR moves a few of the subroutines that were originally encapsulated within an if statement into separate functions which are called through the use of dictionary lookups instead (all operations starting with 00). Unit tests added to catch new conditions. This PR closes #27

Copy link

codecov bot commented Jun 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.37%. Comparing base (1da3918) to head (87b989b).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   90.27%   90.37%   +0.10%     
==========================================
  Files           4        4              
  Lines         473      478       +5     
==========================================
+ Hits          427      432       +5     
  Misses         46       46              
Files Coverage Δ
chip8/cpu.py 97.36% <100.00%> (+0.03%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e64371...87b989b. Read the comment docs.

@craigthomas craigthomas merged commit e49245f into main Jun 23, 2024
3 checks passed
@craigthomas craigthomas deleted the bitplane-register branch June 24, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Bitplane Selection
1 participant