Add Bitplane Control #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
==========================================
+ Coverage 90.27% 92.41% +2.14%
==========================================
Files 4 4
Lines 473 620 +147
==========================================
+ Hits 427 573 +146
- Misses 46 47 +1
Continue to review full report in Codecov by Sentry.
|
Fix problems with incorrect opcode for register subset store / read. Fix problem with scrolling left on bitplane 3. Update README to include new colors. Add unit tests to cover bitplane 0 edge cases. Add missing test for exception on bad 5xxx opcode.
craigthomas
force-pushed
the
bitplane-implementation
branch
from
eb1f862 to
25651ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces bitplanes to the emulator. A second drawing plane exists that can be targeted and blitted to separately from the original bitplane. In addition to this new functionality, a fix was added for storing and loading subsets of registers. The original issues reported that that functionality existed for
Fxy2andFxy3, which was incorrect. This has now been moved to5xy2and5xy3respectively. Unit and integration tests updated accordingly. This PR closes #28