Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: investigate ci linter issues #67

Merged
merged 17 commits into from
Jun 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ jobs:
uses: actions/setup-go@v3
with:
go-version: ^1.21
id: go

- name: Check go mod is tidy
run: |
Expand All @@ -33,7 +32,5 @@ jobs:
- name: Run staticcheck
run: staticcheck ./...

- name: Install golangci-lint
run: go install github.com/golangci/golangci-lint/cmd/[email protected]
- name: Run golangci-lint
run: golangci-lint run
- name: golangci-lint
uses: golangci/golangci-lint-action@v6
21 changes: 5 additions & 16 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,10 @@ linters:
#
# Maybe fix later:
#
- goerr113
- mnd
- depguard
- testifylint
- err113
- stylecheck
- tagliatelle

Expand All @@ -32,28 +35,14 @@ linters:
- contextcheck
- rowserrcheck
- sqlclosecheck
- structcheck
- wastedassign

#
# Disabled because deprecated:
#
- deadcode
- exhaustivestruct
- golint
- ifshort
- interfacer
- maligned
- nosnakecase
- scopelint
- varcheck

linters-settings:
gofumpt:
extra-rules: true
gosec:
excludes:
- G404 # Insecure random number source (rand)
- G404 # Insecure random number source (rand)
govet:
enable-all: true
disable:
Expand Down
Loading