Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Turn off failing fast on the test matrix slots #413

Merged
merged 1 commit into from
Jan 11, 2024
Merged

CI: Turn off failing fast on the test matrix slots #413

merged 1 commit into from
Jan 11, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented Nov 24, 2023 •
edited
Loading

About

This is meant to support GH-408, so that we can get successful outcomes on the Python >= 3.8 slots already.

It is intended to be a temporary change, for a better overview. It can be reverted to save resources on daily operations later.

@amotl
CI: Turn off failing fast on the test matrix slots
a349550 
This is intended to be a temporary change in order to accompany a
subsequent patch. It can be reverted to save resources on daily
operations later.
@amotl amotl requested review from seut and mkleen November 24, 2023 12:54
@amotl amotl marked this pull request as ready for review November 24, 2023 12:54
seut
seut requested changes Nov 24, 2023
View reviewed changes
Copy link
Member

@seut seut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not add this change directly to the relevant PR #408 instead?

@amotl
Copy link
Member Author

amotl commented Nov 24, 2023

Why not add this change directly to the relevant PR #408 instead?

I did not want to push to other's branches without previous coordination. But now that we are talking about it, we can well do it like this. Alternatively, @pilosus might just want to pick it up without further ado? ;]

@amotl amotl merged commit 5029b2b into master Jan 11, 2024
21 checks passed
@amotl amotl deleted the amo/ci-fail-fast-off branch January 11, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seut seut seut requested changes

@mkleen mkleen Awaiting requested review from mkleen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amotl @seut