Npgsql: Use EnableDynamicJson to unlock better container type mappings
#777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
force-pushed
the
npgsql-type-mapping
branch
2 times, most recently
from
5bd679a to
e88bbc5
Compare
amotl
force-pushed
the
npgsql-type-mapping
branch
from
e88bbc5 to
5fdd7ff
Compare
Vanilla Npgsql provides good enough support to handle CrateDB's ARRAY and OBJECT types better than just plain strings. This patch demonstrates type mappings to native .NET `List` and `Dictionary` types, as well as type mappings to custom .NET POCO types.
CrateDB's OBJECT data type can also be communicated using .NET's native `System.Text.Json.JsonDocument` type.
amotl
force-pushed
the
npgsql-type-mapping
branch
from
5fdd7ff to
970c259
Compare
kneth
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This patch resolves a few FIXME admonitions introduced by a recent patch that started to validate all of CrateDB's data types with Npgsql.
Npgsql.CrateDBinstead of vanillaNpgsql#776Details
Vanilla Npgsql provides good enough support to handle CrateDB's ARRAY and OBJECT types better than just plain strings. This patch demonstrates type mappings using three different variants:
System.Collections.Generic.ListandSystem.Collections.Generic.Dictionarytypes.System.Text.Json.JsonDocumenttype. 1 Thanks, @simonprickett.What's Inside
NpgsqlDbType.Jsonexplicitly where applicable, for example when communicating parameters usingAddWithValue().EnableDynamicJson()on theNpgsqlDataSourceBuilder, for POCO andDictionarymappings that didn't work before.What's Next
Include relevant information into a dedicated documentation page, in order to educate readers properly in the spirit of "seeing is believing".
Footnotes
Currently works with OBJECT for me, but not ARRAY. ↩