MongoDB Full: Refactor transformation subsystem to commons-codec
#269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
commented
Sep 18, 2024
pyproject.toml
Outdated
| "commons-codec[mongodb,zyp]>=0.0.15", | ||
| "commons-codec[mongodb,zyp] @ git+https://github.com/crate/commons-codec.git@mongodb-full-next", |
There was a problem hiding this comment.
Needs to be changed after a corresponding release.
There was a problem hiding this comment.
commons-codec v0.0.16 has been released. ✅
Comment on lines
-241
to
+240
| # FIXME: Why does the "canonical format" yield worse results? | ||
| assert timestamp_type == "text" | ||
| assert timestamp_type == "bigint" |
amotl
force-pushed
the
mongodb-full-next
branch
from
0738f02 to
7237a20
Compare
amotl
force-pushed
the
mongodb-full-next
branch
from
7237a20 to
b7b096f
Compare
amotl
force-pushed
the
mongodb-full-next
branch
from
b7b096f to
147f45d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
The
MongoDBFullLoadTranslatorhas been generalized on behalf of recent improvements. This patch just slots it into the right place to make it reusable, atcommons-codec.References