Add basic utility command ctk tail, for tailing a database table and optionally following the tail
#330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
force-pushed
the
tail
branch
2 times, most recently
from
3a5cfbc to
397c8a5
Compare
seut
reviewed
Dec 17, 2024
| @click.option("--format", "format_", type=str, required=False, help="Select output format. Default: log / jsonl") | ||
| @click.option("--follow", "-f", is_flag=True, required=False, help="Follow new records added, by polling the table") | ||
| @click.option("--verbose", is_flag=True, required=False, help="Turn on logging") | ||
| @click.option("--debug", is_flag=True, required=False, help="Turn on logging with debug level") |
There was a problem hiding this comment.
Looks like the --interval option is not defined and passed through?
... and optionally following the tail.
It is mostly sufficient and still provides enough interactivity. By reducing the frequency, it will incur less spam on sys.jobs_log itself.
seut
approved these changes
Dec 18, 2024
Comment on lines
+20
to
+29
| @click.option( | ||
| "--lines", "-n", type=int, required=False, default=10, help="Displays n last lines of the input. Default: 10" | ||
| ) | ||
| @click.option("--format", "format_", type=str, required=False, help="Select output format. Default: log / jsonl") | ||
| @click.option("--follow", "-f", is_flag=True, required=False, help="Follow new records added, by polling the table") | ||
| @click.option( | ||
| "--interval", "-i", type=float, required=False, help="When following the tail, poll each N seconds. Default: 0.5" | ||
| ) | ||
| @click.option("--verbose", is_flag=True, required=False, help="Turn on logging") | ||
| @click.option("--debug", is_flag=True, required=False, help="Turn on logging with debug level") |
There was a problem hiding this comment.
Any reason not to use click default option settings for all default values instead of later on inside the code?
There was a problem hiding this comment.
If the defaults would be applied to click, they wouldn't apply when using ctk's Python APIs in your own programs, that's why I decided to put them there, also to avoid redundancy declaring them on both sides.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Implement
tail -fforsys.jobs_log, to support ad hoc tracing of SQL statements processed by CrateDB.Synopsis
export CRATEDB_SQLALCHEMY_URL=crate://crate@localhost:4200/ctk tail -n 3 --follow --format=log-pretty sys.jobs_log crash -c "SELECT * FROM sys.summits LIMIT 3;"The implementation may be versatile enough to also work well on arbitrary tables.
Documentation
References
tail -fon top ofsys.jobs_logtable #171