Skip to content

Commit

Permalink
Project: Don't use poetry.lock, because it's a library
Browse files Browse the repository at this point in the history
Otherwise, scheduled runs would not use the most recent libraries
relative to their version constraints, so it would defer a fragment
of the continuous testing procedure.

Versions pinned in `poetry.lock` files will net have any meaning for
downstream users installing your package anyway, and, as such, are only
suitable for exact-pinning dependency versions of _applications_.

On the other hand, _libraries_ need to work with a wide range of
dependencies up and down, and are, as such, not suitable for applying
corresponding exact-pinning procedures.
  • Loading branch information
amotl committed Dec 16, 2024
1 parent dd82356 commit 9423038
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2,245 deletions.
6 changes: 0 additions & 6 deletions .github/workflows/_lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,6 @@ jobs:
run: |
poetry check
- name: Check lock file
shell: bash
working-directory: ${{ inputs.working-directory }}
run: |
poetry lock --check
- name: Install dependencies
# Also installs dev/lint/test/typing dependencies, to ensure we have
# type hints for as many of our libraries as possible.
Expand Down
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,6 @@ __pycache__
.idea
.mypy_cache
coverage.xml
# Don't use `poetry.lock`, because it's a library.
# https://github.com/python-poetry/poetry/issues/2861
poetry.lock
Loading

0 comments on commit 9423038

Please sign in to comment.