Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rootless support #124

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Add rootless support #124

merged 2 commits into from
Nov 14, 2024

Conversation

vvoland
Copy link
Collaborator

@vvoland vvoland commented Nov 6, 2024

Wire up rootless config to the new rootless Install option.

@crazy-max
Copy link
Owner

@vvoland #125 has been merged

@vvoland vvoland force-pushed the rootless branch 2 times, most recently from 511bb41 to 8ba5d61 Compare November 8, 2024 09:18
@vvoland vvoland marked this pull request as ready for review November 8, 2024 09:37
action.yml Show resolved Hide resolved
@crazy-max
Copy link
Owner

Pushed extra commit with a rootless job for ci and seems it fails: https://github.com/crazy-max/ghaction-setup-docker/actions/runs/11740833994/job/32708245277#step:3:45

image

@vvoland
Copy link
Collaborator Author

vvoland commented Nov 8, 2024

Oh, I see. I forgot that rootlesskit is also in the rootless-extras. Wondering how did the integration test in actions-toolkit pass though? 🤔

EDIT: Oh, actually the downloaded binaries were added to PATH and it persisted over the multiple test cases, so it had the rootlesskit from the previous image install!

Fixing that up in: docker/actions-toolkit#486

@crazy-max
Copy link
Owner

#126 has been merged if you want to rebase

Wire up `rootless` config to the new `rootless` Install option.

Signed-off-by: Paweł Gronowski <[email protected]>
@crazy-max crazy-max merged commit 332d315 into crazy-max:master Nov 14, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants