Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim input value and add exception handling for invalid URL #298

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shivam8112005
Copy link

Fixes

Description

  • Trimmed the input query value to remove leading and trailing whitespace before processing the form.
  • Added validation to ensure that the search query is not empty before proceeding.
  • Included exception handling when navigating to the generated URL to catch and log any potential errors during the URL opening process.
  • Improved debugging by printing error messages to the console for better visibility during development.

Technical details

  1. Trimmed input query to remove whitespace for cleaner searches.
  2. Added validation to check for empty queries and selected search engines before building the URL.
  3. Implemented error handling for window.open(), logging errors to the console for debugging.

Tests

  1. Verify that input queries are correctly trimmed.
  2. Check alerts for empty queries or unselected search engines.
  3. Test successful URL openings with valid queries and engines.
  4. Induce errors in URL building and confirm console error logs.

Screenshots

Before:

Screen.Recording.2024-10-16.171042.mp4

After:

Screen.Recording.2024-10-16.171113.mp4

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@shivam8112005 shivam8112005 requested a review from a team as a code owner October 16, 2024 11:49
@shivam8112005 shivam8112005 requested review from TimidRobot and possumbilities and removed request for a team October 16, 2024 11:49
Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for cc-search-portal ready!

Name Link
🔨 Latest commit d434ec0
🔍 Latest deploy log https://app.netlify.com/sites/cc-search-portal/deploys/670fa8355b59fd0008716691
😎 Deploy Preview https://deploy-preview-298--cc-search-portal.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shivam8112005
Copy link
Author

hello @possumbilities can you please review this pr when you're free.

@shivam8112005
Copy link
Author

@possumbilities can you please review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

[Bug] Validate and Trim Input Field
1 participant