Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/scroll to top issue54 #137

Closed

Conversation

Daodu111
Copy link

@Daodu111 Daodu111 commented Oct 8, 2024

Fixes

Description

I have worked on the comments you made here https://github.com/creativecommons/vocabulary/pull/65#issuecomment-2391867093

Technical details

Tests

Screenshots

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Daodu111 Daodu111 requested review from a team as code owners October 8, 2024 06:23
@Daodu111 Daodu111 requested review from TimidRobot, Shafiya-Heena, possumbilities, MuluhGodson and hugosolar and removed request for a team October 8, 2024 06:23
Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for vocabulary-docs ready!

Name Link
🔨 Latest commit 9a851c4
🔍 Latest deploy log https://app.netlify.com/sites/vocabulary-docs/deploys/6704f45457bf4b000837bf90
😎 Deploy Preview https://deploy-preview-137--vocabulary-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@egbadon-victor
Copy link
Contributor

egbadon-victor commented Oct 8, 2024

HI @Daodu111

I think the issue here is that out of the 4 commits that are in this pull request, there are 2 that have nothing to do with the scroll to top functionalilty, which are the ones concerning fixing active state in the primary menu.

Ideally, a PR should only contain commits that address the tagged issue. My guess is that you have worked on 2 issues on one branch. I would suggest you create a new branch and then fix the scroll to top issue only, then create a PR for it. Here is a link to my PR for this same issue for context.

Here is the PR

@Daodu111 Daodu111 closed this by deleting the head repository Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

[Feature] Add a scroll-to-top element to UX for longer page contexts
3 participants