[Feature] Implements close icon for vocabulary

[egbadon-victor]

Fixes

• Fixes [Feature] Include Close Icon in the vocabulary design system #304 by @egbadon-victor

Description

This PR adds a close icon to to the vocabulary source files.

Technical details

The SVG implementation was gotten from the official font awesome website, then resized to be compatible with the existing viewBox="0 0 30 30" property.

Tests

• Launch the project on your browser on your local machine
• Go to any test context, and implement a close icon using the following code
  <span class="icon-replace fa-close">Close</span>
  -Observe the close icon displays properly

Checklist

• My pull request has a descriptive title (not a vague title like Update index.md).
• My pull request targets the default branch of the repository (main or master).
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no
  visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[netlify]

✅ Deploy Preview for vocabulary-docs ready!

Name	Link
🔨 Latest commit	9be8eb0
🔍 Latest deploy log	https://app.netlify.com/sites/vocabulary-docs/deploys/6744b73c8aaa7a0008369ab1
😎 Deploy Preview	https://deploy-preview-311--vocabulary-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[possumbilities]

This appears to be erroneous?

[egbadon-victor]

@possumbilities my thought was to accomodate for both an .icon-attach and an .icon-replace instance. But if the .icon-attach usecase is not necessary, I can remove it

[possumbilities]

I meant it looks like line 237 is a duplicate of fa-instagram even though this PR is for fa-close?

this section is a duplicate of line 249 as it currently is

and line 261 already has an fa-close for replacing?

[egbadon-victor]

Aha! I see the issue. fa-instagram was duplicated. That was a mistake.

The for closing, i would remove the .icon-attach implementation inline 233,since a single .icon-replace implementation would suffice. I had in mind that having the two would give flexibility for any contibutor that might want to implement it

[possumbilities]

it's fine to have attach and replace for fa-close. It was just the instagram duplication mistake that needs addressing :)

[egbadon-victor]

Mr Quick fingers has removed the attach implementation 🥲.

I have removed the duplicate instrgram implementation

[egbadon-victor]

all good now :)