Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relaxed a bit the manifest file to compile on ghc-7.6.2 #91

Closed
wants to merge 1 commit into from

Conversation

adinapoli
Copy link

It would be also cool if you release the current github version on Hackage, due to the fact the one on the Hackage is a bit too restrictive, forcing you to use Cabal 0.14

Cheers,
A.

@jtdaugherty
Copy link
Contributor

Thanks for the pull request. Can you elaborate a bit on the change? I don't understand how the impl check change would have improved things on GHC 7.6.2. Also, we tend to wait until just prior to release before changing the version, since that depends on what else is included in the release. So please roll that part back; otherwise this looks good once we have more details.

@jtdaugherty
Copy link
Contributor

As for actually uploading a release, we need more help testing it before it's ready. Right now some tests are failing and some of us haven't had time to figure out why; if you could help us test, that would greatly speed up the process! Please see #74.

@@ -53,7 +53,7 @@ Cabal-version: >=1.6
Data-Files:
admin/cabal-config.in,
admin/00-index.tar
Tested-with: GHC == 6.12.3, GHC == 6.10.4, GHC == 7.0.3, GHC == 7.4.1
Tested-with: GHC == 6.12.3, GHC == 6.10.4, GHC == 7.0.3, GHC == 7.4.1, GHC == 7.6.2
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we must agree upon "Tested-with". Probably, it's safer to remove the 7.6.2 version, since I still hadn't time to play with it.

@adinapoli
Copy link
Author

I've added a bunch of notes in the changes :) See if they makes sense :)
ps. If you are uncertain on the outcome, we could create a separate branch (ghc 7.6.x or whatever) and fiddle with this cabal file without breaking the master build :)

@adinapoli
Copy link
Author

I've decided to simply close this issue, since it doesn't add anything on the table :)
I hope to see the new cabal-dev soon on Hackage :)

Cheers,
A.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants