Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify injections in prelude, and move to Rust edition 2024 #1381

Merged
merged 12 commits into from
Feb 27, 2025

Conversation

jhjourdan
Copy link
Collaborator

@jhjourdan jhjourdan commented Feb 25, 2025

See commits.

Fixes #1380.

This was just an opaque wrapper with axioms... This can slow provers down.
Among other: do not use Term::Cur/Term::cur to dereference shared borrows or Box.
- Remove handler calls for pure operators
- Refactor handling of operators in program.rs
- of_int/to_int : do not provide an axiom of_to_int: it may create matching
  loops with to_of_int. Instead, provide an extensionality axiom
- Add UInteger
- Add missing operators in prelude (espetially for Bool).
- Rename module Intrinsic -> Any
Most important change: use Box<[_]> instead of Vec<_>
@jhjourdan jhjourdan enabled auto-merge February 25, 2025 23:12
@ia0
Copy link

ia0 commented Feb 26, 2025

This would be fixing #1380 right? I can see ord_logic_impl!(char, "prelude.prelude.Char"); in the "Simplify prelude and generated coma code" commit. However if I understand correctly it's not modeled as Int but Char and I must use to_int to get the Unicode scalar value.

@jhjourdan
Copy link
Collaborator Author

This would be fixing #1380 right? I can see ord_logic_impl!(char, "prelude.prelude.Char"); in the "Simplify prelude and generated coma code" commit. However if I understand correctly it's not modeled as Int but Char and I must use to_int to get the Unicode scalar value.

Indeed.

@jhjourdan jhjourdan disabled auto-merge February 27, 2025 23:03
@jhjourdan jhjourdan merged commit 01ed232 into master Feb 27, 2025
6 checks passed
@jhjourdan jhjourdan deleted the simplify_injections branch February 27, 2025 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

char doesn't implement View
2 participants