Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update constants.py to include model #1627

Closed

Conversation

Jacques-Murray
Copy link

This pull request includes updates to the src/crewai/cli/constants.py file to add a new key to the configuration and remove unnecessary whitespace.

Configuration updates:

Code cleanup:

Update constants.py to include model as key_name for ollama.
Copy link

@joaovictorcamargo joaovictorcamargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functions like get_env_vars, get_providers, and get_models could be added to encapsulate configurations and facilitate maintenance.

- Add get_env_vars() to access provider environment variables
- Add get_providers() to retrieve supported providers list
- Add get_models() to access provider model configurations

These functions improve code maintainability by encapsulating configuration access.
@Jacques-Murray
Copy link
Author

Created a new PR: #1631

@bhancockio
Copy link
Collaborator

Fixed by #1638

@bhancockio bhancockio closed this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants