Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

also add packages that are placed in src folder #116

Merged
merged 1 commit into from
Nov 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cluster_pack/packaging.py
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,10 @@ def _get_editable_requirements(executable: str = sys.executable) -> List[str]:
top_level_pkgs = []
for pkg in _get_packages(True, executable):
location = pkg.get("editable_project_location", pkg.get("location", ""))
for _pkg in setuptools.find_packages(location):
packages_found = set(
setuptools.find_packages(location) + setuptools.find_packages(f"{location}/src")
)
for _pkg in packages_found:
if "." in _pkg:
continue
imported = __import__(_pkg)
Expand Down
20 changes: 18 additions & 2 deletions tests/test_packaging.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,17 @@ def test__get_editable_requirements():
assert "user_lib2" in pkg_names


def test__get_editable_requirements_for_src_layout():
with tempfile.TemporaryDirectory() as tempdir:
_create_venv(tempdir)
_pip_install(tempdir, use_src_layout=True)
editable_requirements = packaging._get_editable_requirements(f"{tempdir}/bin/python")
assert len(editable_requirements) == 2
pkg_names = [os.path.basename(req) for req in editable_requirements]
assert "user_lib" in pkg_names
assert "user_lib2" in pkg_names


@pytest.mark.skipif(sys.version_info < (3, 7), reason="requires python3.7 or higher")
def test__get_editable_requirements_withpip23():
with tempfile.TemporaryDirectory() as tempdir:
Expand All @@ -90,10 +101,11 @@ def _create_venv(tempdir: str):
subprocess.check_call([sys.executable, "-m", "venv", f"{tempdir}"])


def _pip_install(tempdir: str, pip_version: str = "18.1"):
def _pip_install(tempdir: str, pip_version: str = "18.1", use_src_layout: bool = False):
subprocess.check_call([f"{tempdir}/bin/python", "-m", "pip", "install",
"cloudpickle", f"pip=={pip_version}"])
pkg = _get_editable_package_name()
pkg = (_get_editable_package_name_src_layout() if use_src_layout
else _get_editable_package_name())
subprocess.check_call([f"{tempdir}/bin/python", "-m", "pip", "install", "-e", pkg])
if pkg not in sys.path:
sys.path.append(pkg)
Expand All @@ -103,6 +115,10 @@ def _get_editable_package_name():
return os.path.join(os.path.dirname(__file__), "user-lib")


def _get_editable_package_name_src_layout():
return os.path.join(os.path.dirname(__file__), "user-lib-src-layout")


def test_get_current_pex_filepath():
with tempfile.TemporaryDirectory() as tempdir:
path_to_pex = f"{tempdir}/out.pex"
Expand Down
Empty file.
8 changes: 8 additions & 0 deletions tests/user-lib-src-layout/setup.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
#!/usr/bin/env python3

import setuptools

setuptools.setup(
name='user_lib_src_layout',
version='0.0.1',
packages=setuptools.find_packages())
Empty file.
2 changes: 2 additions & 0 deletions tests/user-lib-src-layout/src/user_lib/test.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
def test_method():
print("Hello World!")
Empty file.