filesystem.resolve_filesystem_and_path: Fix host for HDFS #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `fsspec.url_to_fs` resulted in using an incorrect host value
for instantiating HDFS filesystems.
For example `fsspec.url_to_fs("viewfs://root/user/someone")` would
call `fsspec.filesystem("viewfs", host="root")`, which could cause
errors. Instead in this case we need the host to be `viewfs://root`, so
we restore most of the code of that function from before #128.
However since we're using fsspec we can generalize to all its supported
file system implementations.
jcuquemelle
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
fsspec.url_to_fsresulted in using an incorrect host value for instantiating HDFS filesystems.For example
fsspec.url_to_fs("viewfs://root/user/someone")would callfsspec.filesystem("viewfs", host="root"), which could cause errors. Instead in this case we need the host to beviewfs://root, so we restore most of the code of that function from before #128.However since we're using fsspec we can generalize to all its supported file system implementations.