-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): add SNMP configuration #36
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpetremann
requested changes
Jun 18, 2024
kpetremann
reviewed
Jun 18, 2024
kpetremann
reviewed
Jun 24, 2024
kpetremann
reviewed
Jun 24, 2024
kpetremann
reviewed
Jul 1, 2024
As OpenConfig doesn't have SNMP configuration, we use the IETF YANG model defined in RFC 7407: https://datatracker.ietf.org/doc/rfc7407/ This review includes: - An ingestor from the NetBox-Network-CMDB SNMP API endpoint. - Generate IETF Go code from the YANG model. - A converter to map NetBox-Network-CMDB to the YANG model. - Create new endpoints: - /v1/devices/:hostname/ietfconfig - /v1/devices/:hostname/config
kpetremann
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As OpenConfig doesn't have SNMP configuration, we use the IETF YANG model defined in RFC 7407: https://datatracker.ietf.org/doc/rfc7407/
This review includes:
netbox endpoint: