New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ldap): deadlock when failed to connect to LDAP #38

Merged

kpetremann merged 1 commit into criteo:main from kpetremann:main

Sep 13, 2024

Contributor

kpetremann commented Sep 13, 2024

Deadlock happened when failed to reconnect to the LDAP because we send a response to the channel twice:

line 109: once during the failure handling
line 137: reached because of the for loop break

note: auth is false by default.


          fix(ldap): deadlock when failed to connect to LDAP

2ca992b

kpetremann requested review from a team

September 13, 2024 10:54

fdomain approved these changes

View reviewed changes

Contributor

fdomain left a comment

good catch

kpetremann merged commit 23228f9 into criteo:main

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet