Skip to content

Commit

Permalink
Enable the rule no-empty-function
Browse files Browse the repository at this point in the history
This rule comes from @typescript-eslint. The base rule no-empty-function is disabled following the doc: https://typescript-eslint.io/rules/no-empty-function/#how-to-use
  • Loading branch information
Xavier Dupessey committed Mar 6, 2024
1 parent 5f603bf commit c1e472a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,7 @@ Some of these have custom config to better address our specific use cases.
| RxJS | `rxjs/finnish` (with custom config) | https://github.com/cartant/eslint-plugin-rxjs/blob/main/docs/rules/finnish.md ||| | |
| RxJS | `rxjs/no-unsafe-takeuntil` (with custom config) | https://github.com/cartant/eslint-plugin-rxjs/blob/main/docs/rules/no-unsafe-takeuntil.md ||| | |
| TypeScript | All recommended rules from `@typescript-eslint` | https://github.com/typescript-eslint/typescript-eslint/tree/main/packages/eslint-plugin#supported-rules |||||
| TypeScript | `no-empty-function` | https://typescript-eslint.io/rules/no-empty-function/ |||||
| eslint-comments | All recommended rules from `eslint-comments` | https://mysticatea.github.io/eslint-plugin-eslint-comments/rules/ |||||
| eslint-comments | `eslint-comments/disable-enable-pair` (custom config to allow whole-file disables) | https://mysticatea.github.io/eslint-plugin-eslint-comments/rules/disable-enable-pair.html |||||
| eslint-comments | `eslint-comments/require-description` | https://mysticatea.github.io/eslint-plugin-eslint-comments/rules/require-description.html |||||
Expand Down
4 changes: 3 additions & 1 deletion lib/configs/internal/recommended.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,17 @@ module.exports = {
'plugin:eslint-comments/recommended',
],
rules: {
'@typescript-eslint/no-empty-function': 'error',
'criteo/cypress-no-force': 'error',
'criteo/filename': 'error',
'criteo/filename-match-export': ['error', { removeFromFilename: ['.actions'] }],
'criteo/no-indexed-access-on-enums': 'off',
'criteo/no-null-undefined-comparison': 'error',
'criteo/no-spreading-accumulators': 'error',
'criteo/no-indexed-access-on-enums': 'off',
'criteo/no-todo-without-ticket': 'error',
'eslint-comments/disable-enable-pair': ['error', { allowWholeFile: true }],
'eslint-comments/require-description': 'error',
'no-empty-function': 'off',
'no-only-tests/no-only-tests': 'error',
'rxjs/finnish': ['error', { functions: false, methods: false, strict: true }],
'rxjs/no-unsafe-takeuntil': ['error', { alias: ['untilDestroyed'] }],
Expand Down

0 comments on commit c1e472a

Please sign in to comment.