Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tuning: Avoid crash in PerformancePowerProfile #30

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

ErwanAliasr1
Copy link
Collaborator

@ErwanAliasr1 ErwanAliasr1 commented Aug 19, 2024

The current code does not check if the scaling_governor is present before using it, leading to a crash.

To improve this part of the code, this commit is:

  • considering the current_governor instead of the available ones to decide if the tuning should be done
  • adding a check before actually reading the file and ignoring the function if no file is found

This commit fixes issue #25.

@ErwanAliasr1 ErwanAliasr1 requested review from Keruspe and beorn- August 19, 2024 14:24
The current code do not check if the scaling_governor is present before
using it, leading to a crash.

To improve this part of the code, this commit is:
- considering the current_governor instead of the available ones to
  decide if the tuning should be done
- adding a check before actually reading the scaling governor file and
  ignore the function if no file found

This commit fixes issue #25.

Signed-off-by: Erwan Velu <[email protected]>
Copy link
Collaborator

@beorn- beorn- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ErwanAliasr1 ErwanAliasr1 merged commit bf69cb7 into main Aug 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants