-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New tooling for dependency management and building #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arno500
force-pushed
the
new-tooling
branch
3 times, most recently
from
October 28, 2024 17:51
861403d
to
b651ad4
Compare
Arno500
force-pushed
the
new-tooling
branch
11 times, most recently
from
October 29, 2024 16:17
d563850
to
cf0d7c2
Compare
Arno500
force-pushed
the
prepare-new-tooling
branch
from
October 29, 2024 16:27
2c50c2e
to
26412e2
Compare
anisse
reviewed
Oct 29, 2024
I think you forgot to remove setup.py, is that expected? (it shouldn't work anymore without the requirements files) |
anisse
requested changes
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to remove setup.py
Installation is made much more easy thanks to uv. Now everything revolves around the pyproject.toml and uv, only one config and one tool to rule them all. Documentation is included in the README, and the Makefile was kept retro compatible or almost. Signed-off-by: Arno Dubois <[email protected]>
This allows users to install the "graph" group optionally. This is useful for server environments without graphical libraries where you do not need the hwgraph command anyway. Signed-off-by: Arno Dubois <[email protected]>
Also check building, just in case Signed-off-by: Arno Dubois <[email protected]>
Done! |
anisse
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the following configurations:
In favor of a unified build and dependency management system. Everything is configured inside the pyproject.toml and still accessible using the Makefile.
Dependencies are locked in standard using uv with the uv.lock. Everything will now be managed through uv, all at once with a single user interface and a single tool.
Please check the README for instructions