Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tooling for dependency management and building #43

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Conversation

Arno500
Copy link
Contributor

@Arno500 Arno500 commented Oct 28, 2024

I removed the following configurations:

  • tox.ini
  • requirements files
  • setup.py

In favor of a unified build and dependency management system. Everything is configured inside the pyproject.toml and still accessible using the Makefile.
Dependencies are locked in standard using uv with the uv.lock. Everything will now be managed through uv, all at once with a single user interface and a single tool.
Please check the README for instructions

@Arno500 Arno500 force-pushed the new-tooling branch 3 times, most recently from 861403d to b651ad4 Compare October 28, 2024 17:51
@Arno500 Arno500 requested review from anisse and beorn- October 28, 2024 18:05
@Arno500 Arno500 added the enhancement New feature or request label Oct 28, 2024
@Arno500 Arno500 force-pushed the new-tooling branch 11 times, most recently from d563850 to cf0d7c2 Compare October 29, 2024 16:17
@Arno500 Arno500 changed the base branch from main to prepare-new-tooling October 29, 2024 16:17
@Arno500 Arno500 force-pushed the prepare-new-tooling branch from 2c50c2e to 26412e2 Compare October 29, 2024 16:27
@Arno500 Arno500 changed the base branch from prepare-new-tooling to main October 29, 2024 16:38
.gitignore Outdated Show resolved Hide resolved
@anisse
Copy link
Contributor

anisse commented Oct 29, 2024

I think you forgot to remove setup.py, is that expected? (it shouldn't work anymore without the requirements files)

Copy link
Contributor

@anisse anisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to remove setup.py

Installation is made much more easy thanks to uv. Now everything revolves around the pyproject.toml and uv, only one config and one tool to rule them all.
Documentation is included in the README, and the Makefile was kept retro compatible or almost.

Signed-off-by: Arno Dubois <[email protected]>
This allows users to install the "graph" group optionally. This is useful for server environments without graphical libraries where you do not need the hwgraph command anyway.

Signed-off-by: Arno Dubois <[email protected]>
Also check building, just in case

Signed-off-by: Arno Dubois <[email protected]>
@Arno500
Copy link
Contributor Author

Arno500 commented Oct 30, 2024

Done!

@Arno500 Arno500 merged commit 3176dab into main Oct 30, 2024
4 checks passed
@Arno500 Arno500 deleted the new-tooling branch October 30, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants