Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some ruff checks #68

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add some ruff checks #68

wants to merge 9 commits into from

Conversation

Djailla
Copy link

@Djailla Djailla commented Dec 19, 2024

No description provided.

@Djailla
Copy link
Author

Djailla commented Dec 19, 2024

There is an issue with cairo, not related to my PR :(

anisse
anisse reviewed Dec 20, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@anisse anisse mentioned this pull request Dec 20, 2024
Merged
anisse
anisse reviewed Dec 20, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@Arno500
Copy link
Contributor

Arno500 commented Dec 26, 2024 •
edited
Loading

You need to rebase to main so we can run the tests ;)
EDIT: Just did it through the UI, should be OK

@anisse
Copy link
Contributor

anisse commented Dec 30, 2024

Hello @Djailla in hwbench we test every commit, so appending a commit to fix tests won't work, you need to fix the faulty commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anisse anisse anisse left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Djailla @Arno500 @anisse