Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back shebang in generated assembly #161

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

a4z
Copy link
Contributor

@a4z a4z commented Dec 22, 2023

Fixes #160

@a4z
Copy link
Contributor Author

a4z commented Dec 25, 2023

The generated djinni artifact or this PR is used in this generator branch.

When we have merged this change, and merge this change into the support lib, it will be possible in the support lib to select for a PR which generator to choose, release, pre-release, from a PR. (successful PRs must run with release, but it will be possible to fully test the build)

@a4z a4z requested review from freitass and jothepro December 25, 2023 18:28
@a4z
Copy link
Contributor Author

a4z commented Dec 25, 2023

FYI @mutagene ^^ , this will be the way to get in #157 with a tested support lib that shows it's using your generator

@a4z a4z merged commit b2a9f83 into cross-language-cpp:main Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add back the shebang for the generated djinni executable
1 participant