Add CI with shellcheck and Linux target tests. #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexhuszagh
commented
Oct 24, 2022
| format: 'json' | ||
| filter: 'docker/Dockerfile.*' | ||
|
|
||
| - name: Validate Changed Images |
There was a problem hiding this comment.
This might need a 120 minute timeout, since we use crosstool-ng images for most of these, which have quite a long build time.
Alexhuszagh
commented
Oct 24, 2022
| git clone https://github.com/cross-rs/cross/ "${td}" | ||
| cargo build -p xtask | ||
|
|
||
| # copy over our project and build our docker images |
There was a problem hiding this comment.
I don't think it makes any sense to deploy these images, for obvious reasons, but then obviously we don't get cached builds. Not sure if there's a good solution here. Maybe we can save to local file between runs and use it to import the cache?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very basic start towards CI, but it:
targets.toml.This doesn't check if files that the Dockerfile depends on, such as scripts, are changed, but it allows us to do minimal CI without having to run tests or build images for anything that hasn't been obviously updated.