Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add provider managed resource metrics #167

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

BigGold1310
Copy link
Contributor

@BigGold1310 BigGold1310 commented Nov 18, 2024

Description of your changes

Add the standard managed resource metrics to the provider for each of the managed resources.
To support this feature, it also bumps the provider to the crossplane 1.17 version.
Fixes #166

In more detail:

  1. Update crossplane dependencies to 1.17
  2. Fixed golangci-lint to get rid of deprecated warnings and outdated nolint statements
  3. Added metric feature to every managed resource

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Run unit tests and tried provider with metrics enabled if it emits the metrics.

@BigGold1310 BigGold1310 force-pushed the update-166 branch 6 times, most recently from ef106fd to f10beab Compare November 19, 2024 10:59
@dariozachow
Copy link
Collaborator

can you merge the build sub module PR in your branch? #164

@BigGold1310
Copy link
Contributor Author

can you merge the build sub module PR in your branch? #164

Rebased on current main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing provider metrics according to crossplane standard
2 participants