feat(environment-proxy): allow to use proxy settings from the environment #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment Signed-off-by: Barunavo Pal <[email protected]>
|
Hi @arielsepton would you please take a look at this PR, this also relates to the first part of the issue : #39. thanks |
Signed-off-by: Barunavo Pal <[email protected]>
Signed-off-by: Barunavo Pal <[email protected]>
|
Hi @barunavo, Could you confirm if you manually tested to ensure the proxy settings work correctly and that the provider’s original behavior remains unaffected? |
|
HI @arielsepton , Thanks for writing, yes I can confirm, it doesn't affect the existing functionality and we could have the PROXY and NO_PROXY from environment. Thanks |
arielsepton
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested