Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reclaim disk space in an initial step while running the CI jobs #1197

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

ulucinar
Copy link
Collaborator

@ulucinar ulucinar commented Mar 7, 2024

Description of your changes

Relevant PR: upbound/official-providers-ci#188

This PR enables the disk clean-up step in the CI workflow to fix the failing check-diff, unit-tests & local-deploy jobs in this branch. For more context, please refer to upbound/official-providers-ci#188. Please also see this comment.

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Via the job run here and here.

@ulucinar ulucinar changed the base branch from main to release-0.47 March 7, 2024 09:37
@ulucinar ulucinar marked this pull request as draft March 7, 2024 09:37
@ulucinar ulucinar closed this Mar 7, 2024
@ulucinar ulucinar reopened this Mar 7, 2024
@ulucinar ulucinar marked this pull request as ready for review March 7, 2024 10:18
@ulucinar
Copy link
Collaborator Author

ulucinar commented Mar 7, 2024

Please note that the publish-artifacts is expected to fail when consuming the reusable workflow from ulucinar/upbound-provider-aws, because Gtihub does not allow self-hosted runners to be used across different organizations.

The lint job is failing to the memory issues. Please see #1194 & upbound/official-providers-ci#187 regarding this.

…the provider-ci reusable workflow

Signed-off-by: Alper Rifat Ulucinar <[email protected]>
Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ulucinar LGTM!

@ulucinar ulucinar merged commit 130eefd into crossplane-contrib:release-0.47 Mar 7, 2024
9 checks passed
@ulucinar ulucinar deleted the cond-disk-free branch March 7, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants