Generate secret references for the sensitive fields under the spec.initProvider API tree #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Generate the secret references for the sensitive fields under the spec.initProvider API tree. Signed-off-by: Alper Rifat Ulucinar <[email protected]>
from the Go resource schema to the JSON schema. Signed-off-by: Alper Rifat Ulucinar <[email protected]>
|
/test-examples="examples/applications/v1beta2/application.yaml" |
sergenyalcin
approved these changes
Jun 6, 2024
|
/test-examples="examples/applications/v1beta2/application.yaml" |
|
/test-examples="examples/applications/v1beta2/application.yaml" |
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
|
/test-examples="examples/applications/v1beta2/application.yaml" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Depends on: crossplane/upjet#411
This PR bumps upjet to commit
f4f87bab8535from crossplane/upjet#411 and generates the secret references for the sensitive fields under thespec.initProviderAPI tree. For further context, please refer to crossplane/upjet#406.This PR also uses the
traverser.maxItemsSyncschema traverser introduced in crossplane/upjet#411 to sync theMaxItemsconstraints from the Go schema to the JSON schema. For the current set of configured resources in the provider, this is currently not an issue but we are implementing automatic syncing of this constraint (until the JSON schema usage is removed in a major version bump) in case any future resources will need it.I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Via uptest: https://github.com/crossplane-contrib/provider-upjet-azuread/actions/runs/9487439963