Bump upjet to 1.1.6 and switch to the new API for marking as required the fields for some resources #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergen Yalçın <[email protected]> (cherry picked from commit 60c0197)
…ix the example manifest of Environment.composer Signed-off-by: Sergen Yalçın <[email protected]> (cherry picked from commit 3100942)
Signed-off-by: Sergen Yalçın <[email protected]> (cherry picked from commit b9c3ab8)
Signed-off-by: Sergen Yalçın <[email protected]>
sergenyalcin
changed the title
sergenyalcin
changed the title
|
/test-examples="examples/compute/instance.yaml" |
ulucinar
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Thanks @sergenyalcin, lgtm. PR has been reviewed in #490, #486 and #477.
sergenyalcin
merged commit 9d76aad
into
crossplane-contrib:release-1.0
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This change backports the #490 and also generates the new license headers that were introduced from the boilerplate template.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Uptest Run: https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/8359534497