Make MaxItems values consistent between JSON schema and provider schema #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergenyalcin
force-pushed
the
configure-max-items
branch
from
4c25d41 to
8649013
Compare
Signed-off-by: Sergen Yalçın <[email protected]>
sergenyalcin
force-pushed
the
configure-max-items
branch
from
8649013 to
50b5ae4
Compare
|
/test-examples="examples/composer/v1beta2/environment.yaml" |
|
/test-examples="examples/compute/v1beta2/instancefromtemplate.yaml" |
|
/test-examples="examples/container/v1beta2/nodepool.yaml" |
ulucinar
approved these changes
May 16, 2024
There was a problem hiding this comment.
Thanks @sergenyalcin, lgtm. Could you please leave a comment for the failing uptest run as we discussed offline?
|
This test failed because of timeout issue. The creation of the resource takes more than one hour. However, I checked the Console and the creation started. So it is good to go now. About the check-examples job please see this comment: #508 (comment) |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
During tests of the `Convert all singleton lists in the MR APIs to embedded objects' PRs, we observed an issue regarding the inconsistency between the JSON schema and provider schema.
The
GetProviderfunction returns provider configuration in the providers. This function has a parametergenerationProvider. If it is set to true, the JSON schema is used to obtain provider configuration. If it is false, the Go schema is used.In theory, the two schemas are equivalent. However, during tests, we observed inconsistencies in some fields
MaxItemsvalues. This means that we use different schemas during generation and reconciliation.This causes issues with the conversion of singleton lists to embedded objects. This type of change may also cause bigger problems.
This PR makes
MaxItemsvalues consistent between JSON schema and provider schema by manipulating the resource schemas.I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested