Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apigee): implements google_apigee_instance_attachment #580

Merged

Conversation

haarchri
Copy link
Member

@haarchri haarchri commented Jul 22, 2024

Description of your changes

  • add apigee instance-attachment
  • we need an apigee organization with an real projectID - deletion takes around 45 minutes

Fixes #563

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

kubectl get managed
NAME                                                            SYNCED   READY   EXTERNAL-NAME                         AGE
organization.apigee.gcp.upbound.io/apigee-instance-attachment   True     True    organizations/crossplane-playground   8m44s

NAME                                                              SYNCED   READY   EXTERNAL-NAME                AGE
globaladdress.compute.gcp.upbound.io/apigee-instance-attachment   True     True    apigee-instance-attachment   8m44s

NAME                                                        SYNCED   READY   EXTERNAL-NAME                AGE
network.compute.gcp.upbound.io/apigee-instance-attachment   True     True    apigee-instance-attachment   8m44s

NAME                                                                    SYNCED   READY   EXTERNAL-NAME                                                                                                        AGE
connection.servicenetworking.gcp.upbound.io/apigee-instance-attachment   True     True   projects%2Fcrossplane-playground%2Fglobal%2Fnetworks%2Fapigee-instance-attachment:servicenetworking.googleapis.com  8m44s

NAME                                                                  SYNCED   READY   EXTERNAL-NAME                AGE
instanceattachment.apigee.gcp.upbound.io/apigee-instance-attachment   True     True    apigee-instance-attachment   8m44s

NAME                                                        SYNCED   READY   EXTERNAL-NAME                AGE
instance.apigee.gcp.upbound.io/apigee-instance-attachment   True     True    apigee-instance-attachment   8m44s

NAME                                                           SYNCED   READY   EXTERNAL-NAME                AGE
environment.apigee.gcp.upbound.io/apigee-instance-attachment   True     True    apigee-instance-attachment   8m44s

@haarchri haarchri force-pushed the feature/apigee-instance-attachment branch from e656d1d to 7d8550a Compare July 23, 2024 09:25
@haarchri haarchri force-pushed the feature/apigee-instance-attachment branch from 7d8550a to b3babe5 Compare July 23, 2024 09:25
Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @haarchri, left two small comments.

examples/apigee/v1beta1/instanceattachment.yaml Outdated Show resolved Hide resolved
@haarchri haarchri changed the title feat(apigee): add instance-attachment feat(apigee): implements google_apigee_instance_attachment Jul 24, 2024
Signed-off-by: Christopher Haar <[email protected]>
Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@turkenf turkenf merged commit e616db2 into crossplane-contrib:main Jul 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request for google_apigee_instance_attachment resource
2 participants