Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apigee): add apigee-addon-configs #581

Conversation

haarchri
Copy link
Member

Description of your changes

  • add apigee-addon-configs
  • we need an apigee organization with an real projectID - deletion takes around 35 minutes

Fixes #565

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

@haarchri haarchri marked this pull request as draft July 22, 2024 12:43
@haarchri
Copy link
Member Author

@ulucinar @turkenf i see that addon_configs is created as v1beta2 but the controller tries to find the resource via v1beta1 (https://github.com/crossplane-contrib/provider-upjet-gcp/pull/581/files#diff-2ab997274c1777f13f403d1193ad914fe152b0aeffb8ea42bf223319f5d66950R30) any hints what i need to configure that this is working here ?

@haarchri
Copy link
Member Author

looks like related to: crossplane-contrib/provider-upjet-aws#1367

@turkenf
Copy link
Collaborator

turkenf commented Jul 22, 2024

@ulucinar @turkenf i see that addon_configs is created as v1beta2 but the controller tries to find the resource via v1beta1 (https://github.com/crossplane-contrib/provider-upjet-gcp/pull/581/files#diff-2ab997274c1777f13f403d1193ad914fe152b0aeffb8ea42bf223319f5d66950R30) any hints what i need to configure that this is working here ?

Fix PR was merged. Could you please rebase it and try again?

@haarchri
Copy link
Member Author

#586

@haarchri haarchri closed this Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request for google_apigee_addons_config resource
2 participants