Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config.Resource.RemoveSingletonListConversion #411

Merged
merged 6 commits into from
Jun 12, 2024
Merged

Add config.Resource.RemoveSingletonListConversion #411

merged 6 commits into from
Jun 12, 2024

Commits on May 30, 2024

  1. Add config.Resource.RemoveSingletonListConversion to be able to remove 

    already configured singleton list conversions.

- The main use case is to prevent singleton list conversions for
  configuration arguments with single nested blocks.

Signed-off-by: Alper Rifat Ulucinar <[email protected]>
    @ulucinar
    ulucinar committed May 30, 2024
    Configuration menu
    Copy the full SHA
    72ab08c View commit details
    Browse the repository at this point in the history

  2. Export config.TraverseSchemas 

    Signed-off-by: Alper Rifat Ulucinar <[email protected]>
    @ulucinar
    ulucinar committed May 30, 2024
    Configuration menu
    Copy the full SHA
    5265292 View commit details
    Browse the repository at this point in the history

  3. Add config.Provider.TraverseTFSchemas to traverse the Terraform schem… 

    …as of

all the resources of a Provider.

Signed-off-by: Alper Rifat Ulucinar <[email protected]>
    @ulucinar
    ulucinar committed May 30, 2024
    Configuration menu
    Copy the full SHA
    cc76abb View commit details
    Browse the repository at this point in the history

  4. Add traverser.AccessSchema to access the Terraform schema elements 

    Signed-off-by: Alper Rifat Ulucinar <[email protected]>
    @ulucinar
    ulucinar committed May 30, 2024
    Configuration menu
    Copy the full SHA
    5318cd9 View commit details
    Browse the repository at this point in the history

  5. Add traverser.maxItemsSync schema traverser for syncing the MaxItems 

    constraints between the JSON & Go schemas.

- We've observed that some MaxItems constraints in the JSON schemas are not set
  where the corresponding MaxItems constraints in the Go schemas are set to 1.
- This inconsistency results in some singleton lists not being properly converted
  in the MR API.
- This traverser can mitigate such inconsistencies.

Signed-off-by: Alper Rifat Ulucinar <[email protected]>
    @ulucinar
    ulucinar committed May 30, 2024
    Configuration menu
    Copy the full SHA
    f4f87ba View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Add unit tests for traverser.maxItemsSync 

    Signed-off-by: Alper Rifat Ulucinar <[email protected]>
    @ulucinar
    ulucinar committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    361331e View commit details
    Browse the repository at this point in the history