lint

cmd/crowdsec-cli/clibouncer/delete.go

@@ -47,15 +47,14 @@ func (cli *cliBouncers) delete(ctx context.Context, bouncers []string, ignoreMis
 			}
 			log.Warnf("bouncer '%s' is auto-created and cannot be deleted, delete parent bouncer %s instead", bouncerName, parentBouncer)
 			continue
-		} else {
-			//Try to find all child bouncers and delete them
-			for _, childBouncer := range allBouncers {
-				if strings.HasPrefix(childBouncer.Name, bouncerName+"@") {
-					if err := cli.db.DeleteBouncer(ctx, childBouncer.Name); err != nil {
-						return fmt.Errorf("unable to delete bouncer: %w", err)
-					}
-					log.Infof("bouncer '%s' deleted successfully", childBouncer.Name)
+		}
+		//Try to find all child bouncers and delete them
+		for _, childBouncer := range allBouncers {
+			if strings.HasPrefix(childBouncer.Name, bouncerName+"@") {
+				if err := cli.db.DeleteBouncer(ctx, childBouncer.Name); err != nil {
+					return fmt.Errorf("unable to delete bouncer: %w", err)
 				}
+				log.Infof("bouncer '%s' deleted successfully", childBouncer.Name)
 			}
 		}
 

pkg/apiserver/api_key_test.go

@@ -88,6 +88,6 @@ func TestAPIKey(t *testing.T) {
 	assert.Equal(t, "[email protected]", bouncers[1].Name)
 	assert.Equal(t, bouncers[0].APIKey, bouncers[1].APIKey)
 	assert.Equal(t, bouncers[0].AuthType, bouncers[1].AuthType)
-	assert.Equal(t, bouncers[0].AutoCreated, false)
-	assert.Equal(t, bouncers[1].AutoCreated, true)
+	assert.False(t, bouncers[0].AutoCreated)
+	assert.True(t, bouncers[1].AutoCreated)
 }