Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application Security Engine Support #2273

Merged
merged 291 commits into from
Dec 7, 2023
Merged

Application Security Engine Support #2273

merged 291 commits into from
Dec 7, 2023

Conversation

buixor
Copy link
Contributor

@buixor buixor commented Jun 6, 2023

Add a new datasource that:

  • Receives HTTP requests from remediation components
  • Apply rules on them to determine whether they are malicious or not
  • Rules can be evaluated in-band (the remediation component will block the request directly) or out-band (the RC will let the request through, but crowdsec can still process the rule matches with scenarios)

The PR also adds support for 2 new hub items:

  • appsec-configs: Configure the Application Security Engine (which rules to load, in which phase)
  • appsec-rules: a rule that is added in the Application Security Engine (can use either our own format, or seclang)

@github-actions
Copy link

github-actions bot commented Jun 6, 2023

@buixor: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions
Copy link

github-actions bot commented Jun 6, 2023

@buixor: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@buixor
Copy link
Contributor Author

buixor commented Jun 6, 2023

/area agent
/kind feature

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Attention: 1360 lines in your changes are missing coverage. Please review.

Comparison is base (90d3a21) 58.31% compared to head (692d96b) 47.97%.

Files Patch % Lines
pkg/appsec/appsec.go 0.00% 350 Missing ⚠️
pkg/hubtest/hubtest_item.go 0.00% 219 Missing ⚠️
pkg/types/appsec_event.go 0.00% 140 Missing ⚠️
pkg/appsec/coraza_logger.go 0.00% 119 Missing ⚠️
pkg/appsec/request.go 54.24% 92 Missing and 5 partials ⚠️
pkg/appsec/appsec_rules_collection.go 0.00% 74 Missing ⚠️
pkg/hubtest/coverage.go 0.00% 47 Missing ⚠️
pkg/appsec/waf_helpers.go 0.00% 46 Missing ⚠️
pkg/appsec/tx.go 0.00% 43 Missing ⚠️
pkg/hubtest/nucleirunner.go 0.00% 41 Missing ⚠️
... and 13 more
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2273       +/-   ##
===========================================
- Coverage   58.31%   47.97%   -10.35%     
===========================================
  Files         201      129       -72     
  Lines       27045    16831    -10214     
===========================================
- Hits        15771     8074     -7697     
+ Misses       9725     7871     -1854     
+ Partials     1549      886      -663     
Flag Coverage Δ
bats ?
unit-linux ?
unit-windows 47.97% <12.59%> (-3.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buixor buixor marked this pull request as draft June 9, 2023 13:01
@buixor buixor added this to the 1.5.6 milestone Dec 5, 2023
@buixor buixor marked this pull request as ready for review December 5, 2023 13:09
@buixor buixor merged commit 8cca434 into master Dec 7, 2023
14 checks passed
@buixor buixor deleted the coraza_poc_acquis branch December 7, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants