Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly update the cs_syslogsource_parsed_total metric #2608

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

blotus
Copy link
Member

@blotus blotus commented Nov 21, 2023

No description provided.

Copy link

@blotus: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@blotus: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@buixor
Copy link
Contributor

buixor commented Nov 21, 2023

/area agent
/kind enhancement

@blotus
Copy link
Member Author

blotus commented Nov 21, 2023

/kind fix
/area agent

@blotus blotus added kind/fix and removed kind/enhancement New feature or request labels Nov 21, 2023
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a51bce8) 56.73% compared to head (2b399f8) 56.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2608      +/-   ##
==========================================
+ Coverage   56.73%   56.85%   +0.12%     
==========================================
  Files         186      190       +4     
  Lines       25783    26158     +375     
==========================================
+ Hits        14628    14873     +245     
- Misses       9633     9730      +97     
- Partials     1522     1555      +33     
Flag Coverage Δ
bats 38.54% <0.00%> (+<0.01%) ⬆️
unit-linux 55.15% <100.00%> (-0.05%) ⬇️
unit-windows 51.89% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blotus blotus merged commit d7ef51e into master Nov 22, 2023
16 checks passed
@blotus blotus deleted the syslog-acquisition-parsed-metrics branch November 22, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants