-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Explain] Ignore blank lines as crowdsec will anyways #2630
[Explain] Ignore blank lines as crowdsec will anyways #2630
Conversation
@LaurenceJJones: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
@LaurenceJJones: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
/kind enhancement |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2630 +/- ##
==========================================
- Coverage 58.22% 58.18% -0.05%
==========================================
Files 201 201
Lines 27048 27077 +29
==========================================
+ Hits 15750 15754 +4
- Misses 9753 9772 +19
- Partials 1545 1551 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Fix #2610
Add check on stdin for zero length lines.
Expand line checker on files to ignore zero length lines.
Return error if tmp file or target file has no content.
Edit:
Add defer function to cleanup as if we returned early the temporary files were kept.