Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update golangci-lint to 1.62 #3332

Merged
merged 1 commit into from
Nov 27, 2024
Merged

update golangci-lint to 1.62 #3332

merged 1 commit into from
Nov 27, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Nov 15, 2024

  • ensure consistent pointer/value receivers
  • testify: json assertions with dedicated methods

Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 58.45%. Comparing base (2ab93f7) to head (3831f2a).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cmd/crowdsec/main.go 0.00% 2 Missing ⚠️
pkg/appsec/coraza_logger.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3332      +/-   ##
==========================================
+ Coverage   58.43%   58.45%   +0.01%     
==========================================
  Files         351      351              
  Lines       37827    37827              
==========================================
+ Hits        22106    22113       +7     
+ Misses      13817    13812       -5     
+ Partials     1904     1902       -2     
Flag Coverage Δ
bats 41.24% <25.00%> (-0.02%) ⬇️
unit-linux 34.43% <0.00%> (-0.01%) ⬇️
unit-windows 29.68% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

 - ensure consistent pointer/value receivers
 - testify: json assertions with dedicated methods
@mmetc mmetc force-pushed the golangci-lint-v0.62 branch from b6282a1 to 3831f2a Compare November 26, 2024 08:41
@mmetc mmetc added this to the 1.6.5 milestone Nov 27, 2024
@mmetc mmetc merged commit bbe7752 into master Nov 27, 2024
17 checks passed
@mmetc mmetc deleted the golangci-lint-v0.62 branch November 27, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants