Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge from master for 1.6.4 #3337

Merged
merged 1 commit into from
Nov 20, 2024
Merged

merge from master for 1.6.4 #3337

merged 1 commit into from
Nov 20, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Nov 20, 2024

No description provided.

Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 60.58374% with 1445 lines in your changes missing coverage. Please review.

Project coverage is 58.36%. Comparing base (188f580) to head (4255cac).
Report is 1 commits behind head on releases/1.6.x.

Files with missing lines Patch % Lines
cmd/crowdsec-cli/clihubtest/run.go 12.82% 135 Missing and 1 partial ⚠️
cmd/crowdsec-cli/clihubtest/create.go 20.00% 103 Missing and 1 partial ⚠️
cmd/crowdsec-cli/clihubtest/coverage.go 15.12% 100 Missing and 1 partial ⚠️
cmd/crowdsec-cli/climachine/inspect.go 25.95% 95 Missing and 2 partials ⚠️
cmd/crowdsec-cli/clipapi/papi.go 40.70% 61 Missing and 6 partials ⚠️
...isition/modules/wineventlog/wineventlog_windows.go 59.23% 42 Missing and 11 partials ⚠️
pkg/acquisition/modules/http/http.go 81.17% 34 Missing and 14 partials ⚠️
cmd/crowdsec-cli/clibouncer/inspect.go 38.80% 39 Missing and 2 partials ⚠️
cmd/crowdsec-cli/clisupport/support.go 31.03% 32 Missing and 8 partials ⚠️
cmd/crowdsec-cli/climachine/add.go 66.66% 28 Missing and 10 partials ⚠️
... and 87 more
Additional details and impacted files
@@                Coverage Diff                 @@
##           releases/1.6.x    #3337      +/-   ##
==================================================
+ Coverage           50.90%   58.36%   +7.46%     
==================================================
  Files                 326      351      +25     
  Lines               38791    37827     -964     
==================================================
+ Hits                19746    22079    +2333     
+ Misses              17105    13838    -3267     
+ Partials             1940     1910      -30     
Flag Coverage Δ
bats 41.25% <47.03%> (+0.80%) ⬆️
unit-linux 34.38% <18.37%> (+0.44%) ⬆️
unit-windows 29.65% <17.28%> (+1.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@sabban sabban merged commit 523164f into releases/1.6.x Nov 20, 2024
19 checks passed
@sabban sabban deleted the merge-1.6.4 branch November 20, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants