Merge pull request #8 from crusoecloud/fix-ssh-keys

Support vars in validators
crusoecloud · Aug 24, 2023 · 95a2972 · 95a2972
2 parents d35914c + 778229c
commit 95a2972
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/internal/validators/regex_validator.go b/internal/validators/regex_validator.go
@@ -23,6 +23,11 @@ func (v RegexValidator) MarkdownDescription(ctx context.Context) string {
 
 //nolint:gocritic // Implements Terraform defined interface
 func (v RegexValidator) ValidateString(ctx context.Context, req validator.StringRequest, resp *validator.StringResponse) {
+	// skip validation if the value is still unknown, which is the case for vars before evaluation
+	if req.ConfigValue.IsUnknown() {
+		return
+	}
+
 	r := regexp.MustCompile(v.RegexPattern)
 
 	if !r.MatchString(req.ConfigValue.ValueString()) {

diff --git a/internal/validators/ssh_key_validator.go b/internal/validators/ssh_key_validator.go
@@ -20,6 +20,11 @@ func (v SSHKeyValidator) MarkdownDescription(ctx context.Context) string {
 
 //nolint:gocritic // Implements Terraform defined interface
 func (v SSHKeyValidator) ValidateString(ctx context.Context, req validator.StringRequest, resp *validator.StringResponse) {
+	// skip validation if the value is still unknown, which is the case for vars before evaluation
+	if req.ConfigValue.IsUnknown() {
+		return
+	}
+
 	input := req.ConfigValue.ValueString()
 
 	_, _, _, _, err := ssh.ParseAuthorizedKey([]byte(input))