Fix #314: Enroling already enroled course does not give meaningful error #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Squash your commits into one and provide a more meaningful commit message. |
app/src/main/java/crux/bphc/cms/fragments/CourseEnrolFragment.kt
Outdated
Show resolved
Hide resolved
Code-R57
force-pushed
the
enrolment-error
branch
from
818b073 to
0296567
Compare
Code-R57
changed the title
|
The commit subject is too long, and make close #314 the last line. Also add this change to the changelog. |
Code-R57
force-pushed
the
enrolment-error
branch
from
01554bd to
be4f6ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code to refresh the list of currently enrolled courses as in MyCoursesFragment and changed the error toast from "Unknown error occurred" to "Course Already Enrolled".
In most cases, the list gets updated but in case it takes time the toast shows a meaningful error.