This repository has been archived by the owner on Sep 1, 2021. It is now read-only.
Remove remaining traces of Eigen2 #894
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghutchis
reviewed
Jul 6, 2018
| message(STATUS "Cannot find Eigen3, trying Eigen2") | ||
| find_package(Eigen2 REQUIRED) | ||
| else() | ||
| set (EIGEN2_SUPPORT_STAGE10_FULL_EIGEN2_API TRUE) |
There was a problem hiding this comment.
Have you verified that all features work? I seem to remember some problems that still required backwards-compatibility from Eigen3.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all remaining traces of Eigen2, since Eigen3 is now marked as required.