feat(ci): implement PR command /request-review

[aali309]

Welcome to Cryostat! 👋

Before contributing, make sure you have:

• Read the contributing guidelines
• Linked a relevant issue which this PR resolves
• Linked any other relevant issues, PR's, or documentation, if any
• Resolved all conflicts, if any
• Rebased your branch PR on top of the latest upstream main branch
• Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
• Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main

---

Fixes: #1585

Description of the change:

This change will add a label review-requested on the PR when /request-review command is detected and then remove it if the reviewer requested changed on the PR

Motivation for the change:

Raised by Max in the Cryostat team

How to manually test:

1. Run CRYOSTAT_IMAGE=quay.io... sh smoketest.sh...
2. ...

[tthvo]

GITHUB_TOKEN will soon be restrictive after https://github.com/cryostatio/cryostat/pull/1635.

We should explicitly declare permissions here. You mostly need pull_request: write.

[aali309]

Link to the test run aali309/cryostat#16

Looking at this now, the label is being added. i also see this error:

  reviewers="@cryostatio/reviewers"
  
  echo "Adding label 'review-requested' to the PR"
  gh pr edit 11 --add-label "review-requested"
  
  if [ -n "$reviewers" ]; then
    gh pr request-review 11 --reviewer $reviewers
  else
    echo "Requesting review from @cryostatio/reviewer(s) team"
    gh pr request-review 11 --team cryostatio/reviewer(s)
  fi
  shell: /usr/bin/bash -e {0}
  env:
    GITHUB_TOKEN: ***
Adding label 'review-requested' to the PR
https://github.com/aali309/cryostat/pull/11
/home/runner/work/_temp/8dd5f478-5bf9-4dfb-9[2](https://github.com/aali309/cryostat/actions/runs/6038327673/job/16384492648#step:3:2)55-180[3](https://github.com/aali309/cryostat/actions/runs/6038327673/job/16384492648#step:3:3)f82e[4](https://github.com/aali309/cryostat/actions/runs/6038327673/job/16384492648#step:3:4)34[6](https://github.com/aali309/cryostat/actions/runs/6038327673/job/16384492648#step:3:6).sh: line [10](https://github.com/aali309/cryostat/actions/runs/6038327673/job/16384492648#step:3:10): syntax error near unexpected token `('
Error: Process completed with exit code 2.```

[andrewazores]

    echo "Requesting review from @cryostatio/reviewer(s) team"
    gh pr request-review 11 --team cryostatio/reviewer(s)
  fi
  shell: /usr/bin/bash -e {0}
  env:
    GITHUB_TOKEN: ***
Adding label 'review-requested' to the PR
https://github.com/aali309/cryostat/pull/11
/home/runner/work/_temp/8dd5f478-5bf9-4dfb-9[2](https://github.com/aali309/cryostat/actions/runs/6038327673/job/16384492648#step:3:2)55-180[3](https://github.com/aali309/cryostat/actions/runs/6038327673/job/16384492648#step:3:3)f82e[4](https://github.com/aali309/cryostat/actions/runs/6038327673/job/16384492648#step:3:4)34[6](https://github.com/aali309/cryostat/actions/runs/6038327673/job/16384492648#step:3:6).sh: line [10](https://github.com/aali309/cryostat/actions/runs/6038327673/job/16384492648#step:3:10): syntax error near unexpected token `('
Error: Process completed with exit code 2.```

The last part:

syntax error near unexpected token `('

looks like it's probably related to:

    echo "Requesting review from @cryostatio/reviewer(s) team"
    gh pr request-review 11 --team cryostatio/reviewer(s)

There shouldn't be () on reviewers, that's probably the unexpected token the shell is complaining about.

[andrewazores]

Didn't work:

https://github.com/cryostatio/cryostat/actions/runs/6087853970/job/16517292637

 Adding label 'review-requested' to the PR
https://github.com/cryostatio/cryostat/pull/1636
Requesting review from @cryostatio/reviewers
error fetching organization teams: GraphQL: Resource not accessible by integration (organization.teams)
Error: Process completed with exit code 1.

I checked the organization settings and it looks like the reviewers team is publicly readable, so I think this workflow might need to run with some elevated token permissions?

[andrewazores]

It seems to still work regardless of that workflow failure though, somehow...

[aali309]

It seems to still work regardless of that workflow failure though, somehow...

I am quite confused on this one to be honest. Honestly, If you dint explain to me that the --add-reviewer would work the same in a team and individual environment, I would have thought that was the reason.

[andrewazores]

The failure seems to be a permissioning issue ("resource not accessible"), not that the reviewer is a team, so I don't think that really has to do with it.

Anyway, this is not a very high priority thing to troubleshoot, so we can come back around to it later. I'll file a separate bug.